Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fno-toplevel-reorder #5809

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

DizzyEggg
Copy link
Collaborator

Weirdly enough... it works for me.
If CI passes, I'd appreciate others to pull and build it locally to see if it works for them too.

@hedara90
Copy link
Collaborator

I didn't see any immediate issues with it outside of the Birch into platform colors being wrong.

@AsparagusEduardo
Copy link
Collaborator

I didn't see any immediate issues with it outside of the Birch into platform colors being wrong.

Gotta do a pret merge to fix this

@DizzyEggg
Copy link
Collaborator Author

I didn't see any immediate issues with it outside of the Birch into platform colors being wrong.

Awesome. The Birch's intro platform fix is already merged into pret here pret#2075

@AsparagusEduardo
Copy link
Collaborator

Once #5845 is merged, this should too

Copy link
Collaborator

@SBird1337 SBird1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to eventually remove those extra compilation flags for those files, but for now I'm just gonna yolo this one.

@SBird1337 SBird1337 merged commit 6a2a3b2 into rh-hideout:upcoming Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants